[karellenincParticipant]

#9592

Guys, please stop closing threads before the customer said the issue is resolved. Now I can’t ask a simple question, “when the fixes will be released?”

[Bassam TarekKeymaster]

#9593

What fixes you are talking about ?, please you mention a thread that we closed and the issue wasn’t solved yet ?

Thanks

[karellenincParticipant]

#9594

The thread was “Lot’s of invalid CSS in pages affecting rendering” and the issues are the CSS issues mentioned in the thread.

[Bassam TarekKeymaster]

#9595

I don’t get what is the problem, I told you that we have done what we can for now and you replied “This is much better, thank you!”

1- Why do you want this thread to remain opened ?

2- “when the fixes will be released?” : It is already in V3.0 which is the version that you have

[karellenincParticipant]

#9596

1) Because not ALL of the CSS errors have been fixed and I’d like to be able to keep track of the bugs. CriticalCSS.com still fails while parsing CSS on the website and there are CSS 176 parse errors on your website and there are 180 on mine.
2) I don’t know what’s going on with the versioning and Envato. When I download CF theme from Envato, this is the .hg_archival.txt in the zip. Latest tag is V2.6.0

bash-4.3$ cat .hg_archival.txt
repo: 137e34b135d31ce4cd4f63b7b8a2da434a5caa68
node: ca7ac6a823f3d894c1dc79409dbdaaba60d7fb75
branch: default
latesttag: V2.6.0
latesttagdistance: 3
changessincelatesttag: 44

The version I have right now has all the same errors (link below).

[karellenincParticipant]

#9597

This reply has been marked as private.

[Bassam TarekKeymaster]

#9599

Aha i see, you still have an old version, can you try downloading the latest version from here: https://themeforest.net/downloads

[karellenincParticipant]

#9600

@bassam. I did! And I have Envato Marketplace installed in WP. This is what I get when I try to download the latest version. I downloaded one just this second. And I have tag v2.6.0 in the WordPress only zip.

[karellenincParticipant]

#9601

And regardless of the version I have, this link to Creiden has 176 CSS parse errors inside of it:

https://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fthemes.creiden.com%2Fcircleflip%2F&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

[karellenincParticipant]

#9603

In other words, @bassam, you seem to be running the exact version I’m running, which is 2.6.0, if you believe the tag.

[Bassam TarekKeymaster]

#9604

1- Can you open style.css file and tell me the version that is written inside it ? if it is version 3.0 then you are fine

2- Regarding 176 CSS parse errors: yes as i mentioned they are in the bootstrap file, it is not in our plan to fix it now, but soon

Regards

[karellenincParticipant]

#9605

1) My style CSS says 3.0, but all the HG tags say 2.6.0.
2) Bootstrap contains most of the invalid CSS errors. Do you have an ETA for fixing them?

[Bassam TarekKeymaster]

#9607

1) we will delete the .hgtags and archival files, they shouldn’t be packaged in the theme folder that you have, this is only for the development on our repo

The main place that you should be checking this is the style.css comment

2) There is no exact time but We will do our best

[karellenincParticipant]

#9609

@bassam,

Thanks! The issue is that the bootstrap errors are the ones preventing CSS critical section analysis running in the first place it seems and the number of errors is absolutely massive.

[karellenincParticipant]

#9623

@bassam,

Ok, I actually know what’s going on. The latest minified bootstrap 3.3.7 actually contains far fewer errors. Bootstrap used by CF theme is 2.0, which is very very old (4 years old), no longer supported and probably does not support current browsers. The remaining errors in bootstrap 3 are actually vetted and confirmed to be non-issue: https://github.com/twbs/bootstrap/issues/18672

Maybe migration is in order? http://getbootstrap.com/migration/

https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css

https://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Fmaxcdn.bootstrapcdn.com%2Fbootstrap%2F3.3.7%2Fcss%2Fbootstrap.min.css&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en